Skip to content

Commit bc856b1

Browse files
committed
spec: add optional secrets to NodeGetVolumeStatsRequest
For BlockVolume type of volumes, there are very little stats that can be gathered. The only reasonable metric on the Node that is available without knowing the contents of the BlockVolume, is the Total capacity. Different backend storage systems can thin-provision BlockVolumes. Initially the Used storage will be low, and growing over time. This is not detectable through standard Operating System APIs, but the backend storage system can provide more acurate Available/Used stats through expert APIs. In order to allow the Node to retrieve advanced stats from the backend storage system, the secrets that are used for staging the volume can be provided.
1 parent f1ae024 commit bc856b1

File tree

3 files changed

+270
-242
lines changed

3 files changed

+270
-242
lines changed

csi.proto

+7
Original file line numberDiff line numberDiff line change
@@ -1430,6 +1430,13 @@ message NodeGetVolumeStatsRequest {
14301430
// system/filesystem, but, at a minimum, SP MUST accept a max path
14311431
// length of at least 128 bytes.
14321432
string staging_target_path = 3;
1433+
1434+
// Secrets that the plugin can use to request additional statistics
1435+
// from the backend storage system.
1436+
// This field is OPTIONAL. Refer to the `Secrets Requirements`
1437+
// section on how to use this field.
1438+
map<string, string> secrets = 4
1439+
[(csi_secret) = true, (alpha_field) = true];
14331440
}
14341441

14351442
message NodeGetVolumeStatsResponse {

0 commit comments

Comments
 (0)