feat: add signal option to containerRestart #3898
Merged
+46
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coderbirju
changed the title
|
@AkihiroSuda @djdongjin PTAL when you get some time |
AkihiroSuda
reviewed
Feb 20, 2025
| @@ -38,6 +38,7 @@ func NewRestartCommand() *cobra.Command { | |||
| SilenceErrors: true, | |||
| } | |||
| restartCommand.Flags().UintP("time", "t", 10, "Seconds to wait for stop before killing it") | |||
| restartCommand.Flags().StringP("signal", "s", "", "Signal to send to stop the container, before killing it") | |||
There was a problem hiding this comment.
The docs needs to be updated too
https://github.com/containerd/nerdctl/blob/main/docs/command-reference.md#whale-nerdctl-restart
Signed-off-by: Arjun Raja Yogidas <[email protected]>
coderbirju
force-pushed
the
add-signal-container-restart
branch
from
97d0bc0 to
8664311
Compare
|
Added Documentation updates for Stop and Restart container |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up with signal option to containerRestart