Remove hcsshim import from repo

[kiashok]

Move windows CheckHostAndContainerCompat() function from hcsshim locally to platform repo itself

[thaJeztah]

Wondering if we should just copy the whole osversion package as a package in this repository; that way we could possibly automate updating it, and it could be used as a drop-in replacement for the existing package in places where it's used. Would that be an option?

[kiashok]

Wondering if we should just copy the whole osversion package as a package in this repository; that way we could possibly automate updating it, and it could be used as a drop-in replacement for the existing package in places where it's used. Would that be an option?

osversion package is used quite a bit on hcsshim repo and I don't think we want to copy it over to containerd/platforms. Having it in hcsshim repo also gives us the ability to extend/add functionality instead of opening PRs on the containerd/platform repo.
It has very windows specific stuff as well and I am not sure this repo would be the right place. Also, it could break a lot of ppl who are already using osversion package directly from hcsshim.

[dmcgowan]

Thanks for opening this. The needed logic is small enough that we should just maintain it here. Can we get away with making the os version struct and all the functions that use it private, that would help us make sure this package isn't getting used just for handling the version strings.

[thaJeztah]

Also, it could break a lot of ppl who are already using osversion package directly from hcsshim.

So, I don't think we want to remove it there, but importing hcsshim just for that package is usually problematic, and if updates are needed from the osversion package currently means updating all of hcsshim.

This PR will help a lot in that respect, but my thinking was if it would mirror the essentials (so all the consts, and, basically a mirror of the upstream package), that could allow easier updating, and provide github.com/containerd/platforms/osversion as a "drop-in" replacements for situations where importing hcsshim is problematic.

Having it in a osversion package in this repository may me nice?

[kiashok]

Also, it could break a lot of ppl who are already using osversion package directly from hcsshim.

So, I don't think we want to remove it there, but importing hcsshim just for that package is usually problematic, and if updates are needed from the osversion package currently means updating all of hcsshim.

This PR will help a lot in that respect, but my thinking was if it would mirror the essentials (so all the consts, and, basically a mirror of the upstream package), that could allow easier updating, and provide github.com/containerd/platforms/osversion as a "drop-in" replacements for situations where importing hcsshim is problematic.

Having it in a osversion package in this repository may me nice?

The change that is needed by containerd is only the one function for platform matching code. I don't think we want to maintain a mirror of the whole osversion package from hcsshim and add more maintenance of keeping it upto date etc. The only reason checkHostAndContainerCompat() was that platforms package was part of containerd/containerd repo which already needs to import hcsshim. Since that has changed now, it will be easier to just maintain that single function in containerd/platforms.

[kiashok]

cc @kevpar @helsaawy for awareness

[kiashok]

Thanks for opening this. The needed logic is small enough that we should just maintain it here. Can we get away with making the os version struct and all the functions that use it private, that would help us make sure this package isn't getting used just for handling the version strings.

Updated PR with changes.

[thaJeztah]

ok, let's move forward with this, thanks!

LGTM

[kiashok]

@dmcgowan could this PR be merged? Thanks!

[dims]

LGTM