[release/1.1] Fix windows closed pipe error #165
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vincent Batts <[email protected]> (cherry picked from commit 9660e6b) Signed-off-by: Austin Vazquez <[email protected]>
Update GitHub Actions runner OS from Ubuntu 18.04 to Ubuntu 22.04. Update actions/setup-go from v2 to v3. Update Go compiler from Go 1.17 to Go 1.20. Update golangci-lint from v1.45.0 to v1.51.2 for Go 1.20 support. Remove deprecated `-i` flag from make coverage target. Signed-off-by: Austin Vazquez <[email protected]> (cherry picked from commit c7b5a32) Signed-off-by: Austin Vazquez <[email protected]>
Signed-off-by: Austin Vazquez <[email protected]> (cherry picked from commit 589a593) Signed-off-by: Austin Vazquez <[email protected]>
Signed-off-by: Austin Vazquez <[email protected]>
On Windows platforms with Go 1.20+ toolchains io.ErrClosedPipe is returned when the connection is terminated by the remote host. Filter this to ErrClosed. Enables Windows testing in GitHub Actions CI. Signed-off-by: Austin Vazquez <[email protected]>
austinvazquez
force-pushed
the
fix-windows-closed-pipe-error
branch
from
72d0974
to
a481db1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
#164
Description
This change adds
io.ErrClosedPipeto client filter close error to enable unit tests to run on the Windows platform with Go 1.20+ toolchains.Testing
TestClientEOF passes on Windows platform with Go 1.20 toolchain