switch to github.com/containerd/log for logs #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sebastiaan van Stijn <[email protected]>
samuelkarp
approved these changes
Jun 19, 2024
cpuguy83
approved these changes
Jun 19, 2024
estesp
approved these changes
Jun 19, 2024
thaJeztah
commented
Jun 19, 2024
| @@ -368,15 +368,15 @@ func (c *Client) receiveLoop() error { | |||
| sid := streamID(msg.header.StreamID) | |||
| s := c.getStream(sid) | |||
| if s == nil { | |||
| logrus.WithField("stream", sid).Errorf("ttrpc: received message on inactive stream") | |||
| log.G(c.ctx).WithField("stream", sid).Error("ttrpc: received message on inactive stream") | |||
There was a problem hiding this comment.
These contexts embedded in the struct seemed awkward; there's probably a reason for this, or it was written long time ago; wondering if someone knows the background and if this is something that needs to be changed.
(I didn't look into history yet)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.