[skip-ci] RPM/TMT: use tests subpackage #557
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lsm5 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
lsm5
force-pushed
the
rpm-tests-subpackage
branch
3 times, most recently
from
2fbd425 to
f29b9d0
Compare
This makes fetching and running of gating tests similar to podman, buildah and skopeo. Signed-off-by: Lokesh Mandvekar <[email protected]>
lsm5
force-pushed
the
rpm-tests-subpackage
branch
from
f29b9d0 to
f5388be
Compare
Luap99
reviewed
Jan 7, 2025
Comment on lines
+62
to
+63
| # Only intended to be used for gating tests | ||
| # End user usecases not supported |
There was a problem hiding this comment.
should this be part of the description? So end user have actually a chance to read it.
| Requires: jq | ||
| Requires: make | ||
| Requires: netavark | ||
| Requires: nftables |
There was a problem hiding this comment.
Isn't nftables already required by netavark?
| Requires: bind-utils | ||
| Requires: iptables | ||
| Requires: jq | ||
| Requires: make |
There was a problem hiding this comment.
make doesn't seem to be needed to run as your script just calls bats test/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes fetching and running of gating tests similar to podman, buildah and skopeo.