install: Relax restriction on separate /boot #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For example, the current RHEL 9.2 VM images (KVM/cloud-init guest, and at least GCP) don't use a separate `/boot` by default (probably because they don't support LUKS for `/` like CoreOS systems do). Signed-off-by: Colin Walters <[email protected]>
cgwalters
force-pushed
the
release-boot-restriction
branch
from
da9e565 to
7112af2
Compare
cgwalters
commented
Oct 13, 2023
| /// If true, do not try to remount the root read-only and flush the journal, etc. | ||
| skip_finalize: bool, | ||
| boot: MountSpec, | ||
| boot: Option<MountSpec>, |
There was a problem hiding this comment.
Tangentially related...it's in precisely this kind of code refactoring that Rust is great. The compiler found all the places I needed to change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For example, the current RHEL 9.2 VM images (KVM/cloud-init guest, and at least GCP) don't use a separate
/bootby default (probably because they don't support LUKS for/like CoreOS systems do).