Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Test alongside installation in GH Actions #176

Merged
merged 1 commit into from
Nov 3, 2023

Conversation

cgwalters
Copy link
Collaborator

Having a fast disposable VM is good for this. Also we are now verifying that the baseline functionality works to install alongside an Ubuntu system!

Having a fast disposable VM is good for this.  Also we are now
verifying that the baseline functionality works to install alongside
an Ubuntu system!

Signed-off-by: Colin Walters <[email protected]>
@cgwalters
Copy link
Collaborator Author

This also adds additional coverage for the kargs bit for #172

Copy link
Contributor

@jlebon jlebon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat!

@jlebon jlebon enabled auto-merge November 3, 2023 20:21
@cgwalters
Copy link
Collaborator Author

CI / Test install-alongside (pull_request) Successful in 8m

🎉

@jlebon jlebon merged commit 1477166 into containers:main Nov 3, 2023
9 checks passed
- name: Integration tests
run: |
set -xeuo pipefail
sudo podman run --rm -ti --privileged -v /:/target -v ./usr/bin/bootc:/usr/bin/bootc --pid=host --security-opt label=disable \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: --security-opt label=disable is implied by --privileged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants