containerenv: small error message fix #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This tweaks the error message when `.containerenv` cannot be found so that a fully-qualified path is included in the error. Previously, the error message would just show `run/.containerenv` as the path to the file, which is not entirely clear. I tried to change the `const PATH` to be an absolute path, but doing so breaks the ability for `open_optional()` to open the file successfully; returns an error `a path led outside of the filesystem`. Signed-off-by: Micah Abbott <[email protected]>
cgwalters
approved these changes
Nov 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tweaks the error message when
.containerenvcannot be found so that a fully-qualified path is included in the error.Previously, the error message would just show
run/.containerenvas the path to the file, which is not entirely clear.I tried to change the
const PATHto be an absolute path, but doing so breaks the ability foropen_optional()to open the file successfully; returns an errora path led outside of the filesystem.