Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup clippy lints #390

Merged
merged 1 commit into from
Mar 12, 2024
Merged

Cleanup clippy lints #390

merged 1 commit into from
Mar 12, 2024

Conversation

jeckersb
Copy link
Contributor

Signed-off-by: John Eckersberg [email protected]

Signed-off-by: John Eckersberg <[email protected]>
@github-actions github-actions bot added the area/install Issues related to `bootc install` label Mar 12, 2024
Copy link
Collaborator

@cgwalters cgwalters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, not sure what went wrong with the testing farm jobs, I can't get to the logs. I can't imagine this somehow broke it though.

@@ -1232,7 +1232,7 @@ struct RootMountInfo {
/// Discover how to mount the root filesystem, using existing kernel arguments and information
/// about the root mount.
fn find_root_args_to_inherit(cmdline: &[&str], root_info: &Filesystem) -> Result<RootMountInfo> {
let cmdline = || cmdline.iter().map(|&s| s);
let cmdline = || cmdline.iter().copied();
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes I will have to try to remember this one. Maybe we can drop the helper closure even and just inline it in the two uses.

@cgwalters cgwalters merged commit 411c173 into containers:main Mar 12, 2024
14 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/install Issues related to `bootc install`
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants