docs: clarify that --karg can be passed multiple times
#392
Conversation
|
Hi @mvo5. Thanks for your PR. I'm waiting for a containers member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
cgwalters
force-pushed
the
clarify-kargs
branch
from
d9cc323 to
8687270
Compare
We'll handle this another way. Signed-off-by: Colin Walters <[email protected]>
Missed this when doing the mdbook conversion. Signed-off-by: Colin Walters <[email protected]>
It is not clear from the current man-page that `--karg` can be passed multiple times. From reading the code it seems to be the case but because it's not obvious (to me) I also added a small testcase to the CI to ensure that I'm not misreading things. I added a small comment to the docs that it can be given multiple times. Signed-off-by: Michael Vogt <[email protected]> Signed-off-by: Colin Walters <[email protected]>
cgwalters
force-pushed
the
clarify-kargs
branch
from
8687270 to
c7a9f02
Compare
| // Using this option reserves space for partitions created dynamically on the | ||
| // next boot, or by subsequent tools. | ||
| // pub(crate) size: Option<String>, | ||
| /// Add a kernel argument. This option can be provided multiple times. |
There was a problem hiding this comment.
Thank you @cgwalters !
It is not clear from the current man-page that
--kargcan be passed multiple times. From reading the code it seems to be the case but because it's not obvious (to me) I also added a small testcase to the CI to ensure that I'm not misreading things.I added a small comment to the docs that it can be given multiple times.
[draft to double check in CI that it actually works]
P.S. it would be nice to have an easy way to run the CI test locally, especially since they won't run automatically and someone needs to "ack" them first here on GH