Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

status: Rework human readable output #901

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

cgwalters
Copy link
Collaborator

  • Add a circle like rpm-ostree
  • Add a whitespace line between entries
  • Drop not-present entries
  • Rework timestamp+version combo; if there's no version, then show the column as Timestamp; if there's a version but no timestamp, just omit the timestamp
  • Align columns

Closes: #900

@cgwalters cgwalters mentioned this pull request Nov 17, 2024
@tulilirockz
Copy link

Looks absolutely great!

Copy link
Contributor

@djach7 djach7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than requested if statement change

lib/src/glyph.rs Outdated Show resolved Hide resolved
- Add a circle like rpm-ostree
- Add a whitespace line between entries
- Drop not-present entries
- Rework timestamp+version combo; if there's no version, then
  show the column as `Timestamp`; if there's a version but no
  timestamp, just omit the timestamp
- Align columns

Closes: containers#900

Signed-off-by: Colin Walters <[email protected]>
Copy link
Contributor

@djach7 djach7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for updating all of this and making it look much better

@cgwalters cgwalters merged commit 9b96f03 into containers:main Nov 18, 2024
31 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bootc status feedback
3 participants