tests: Add a docstring to fix CI #927
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It looks like with Rust 1.83, `#[deny(missing_docs)]` started triggering for our integration test. It looks like this is a known thing: rust-lang/rust#130203 (comment) Signed-off-by: Colin Walters <[email protected]>
jeckersb
approved these changes
Dec 2, 2024
|
Huh, this pull request got confused, at least in my view of the UX. The bottom shows it as merged, but the top shows the "closed unmerged" icon. |
|
The code landed in git so we're all good anyways. |
cgwalters
added a commit
to antheas/bootc
that referenced
this pull request
Dec 2, 2024
tests: Add a docstring to fix CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like with Rust 1.83,
#[deny(missing_docs)]started triggering for our integration test. It looks like this is a known thing: rust-lang/rust#130203 (comment)