Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wip: Install with fsverity #935

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

cgwalters
Copy link
Collaborator

@cgwalters cgwalters commented Dec 4, 2024

The goal of this PR is to enable in an install config:

[install]
root-fs-type = "ext4"
fsverity = "enabled"

to hard require fsverity for bootc install, and chain it to the ostree config. We're trying to hide the ostree configuration here though.

@github-actions github-actions bot added the area/install Issues related to `bootc install` label Dec 4, 2024
@cgwalters
Copy link
Collaborator Author

Needs a rebase, conflicts should be relatively straightforward to fix

@allisonkarlitskaya
Copy link

Can you explain some scenarios where we might want to have fs-verity disabled? Is it just on filesystems that can't support it? Because even without checking the verity data or anything, I find the "this inode is now immutable" thing to be extremely compelling, particularly in the presence of multiple hardlinks....

@cgwalters
Copy link
Collaborator Author

Can you explain some scenarios where we might want to have fs-verity disabled? Is it just on filesystems that can't support it?

That's by far the biggest case.

However, there is some generic overhead to having it...this isn't quite as relevant for bootc but it would be for taking fsverity in container runtimes in general. There are people that disable selinux to claw back like 1-2% of performance and fsverity is a bit like that, you just have this cost to paging in new code and doing cryptographic verification.

But supporting deploying to filesystems without it is 94.3% of the rationale for bootc.

Because even without checking the verity data or anything, I find the "this inode is now immutable" thing to be extremely compelling, particularly in the presence of multiple hardlinks....

Definitely! Before composefs existed I was trying to push for fsverity in ostree just for this reason...but I struggled with tying it to a higher level integrity story. Thankfully we have that now!

Signed-off-by: Colin Walters <[email protected]>
@cgwalters cgwalters force-pushed the install-config-verity branch from 8379be7 to d045510 Compare December 10, 2024 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/install Issues related to `bootc install` do-not-merge/work-in-progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants