mount: Some error handling fixups #959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivated by containers#957 but probably not any kind of fix in reality. Our error handling here was buggy. What we really should do is avoid `fork()` and do an execve here, but that's a larger refactor. - Close the other side of the socket in the forked child so the parent doesn't hang indefinitely if the child dies before sending - Change the parent to return a clean error if the child doesn't write anything instead of an `assert!` - Check the exit code of the child Signed-off-by: Colin Walters <[email protected]>
omertuc
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivated by #957 but probably not any kind of fix in reality. Our error handling here was buggy. What we really should do is avoid
fork()and do an execve here, but that's a larger refactor.assert!