Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify network configuration when using podman machine #2402

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

chrw
Copy link

@chrw chrw commented Apr 2, 2025

Fixes: containers/podman#25763

Avoid confusion with the network configuration using podman machine.

Copy link
Contributor

openshift-ci bot commented Apr 2, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: chrw
Once this PR has been reviewed and has the lgtm label, please assign tomsweeneyredhat for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@chrw chrw force-pushed the update_containersconf_doc branch from 07a5a84 to bcb7be7 Compare April 2, 2025 14:00
Comment on lines +408 to +410
Note: If Podman is running in a virtual machine using `podman machine` (this
includes Mac and Windows hosts), ensure that you add the configuration in the
virtual machine by using `podman machine ssh`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note this does not only effect network settings, almost all option from this file must be set server side (in the machine). Notable exceptions are [machine], [farms], [engine.service_destinations], compose_providers, compose_warning_logs, and the remote option and likely more we don't even know about.

So I think this should likely be reworded and put as part of the main description. (Overall we as a team are currently trying to figure out how this whole situation can be improved)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure how to rephrase this to ensure that the information isn't overlooked. My thought was that including such a note directly within the configuration type would make sense.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How should we move forward with this change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Podman ignores default_network settings on macOS
2 participants