include name and tag of a container into journald message for syslog [WIP] #273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# summary When writing logs from _conmon_ into _journald_ and post-process the journal with _rsyslog_ or others, there's no way to filter logs from plain _syslog_ messages. This PR prefixes the container's name and its tags (if set) to each message. # syntax `container-name[container-tag]` # examples ## container-name has been set, container-tag has been set `Jun 7 00:00:00 debian conmon[666]: podman-nginx[test-buid-20210706] message` ## only container-name has been set `Jun 7 00:00:00 debian conmon[667]: podman-nginx It works.` ## only container-tag has been set `Jun 7 00:00:00 debian conmon[668]: [test-buid-20210706] It works.` ## neither ... nor ... has been set `Jun 7 00:00:00 debian conmon[669]: It works.`
|
thanks for the PR @tobwen LGTM |
|
one thing of note: I wonder if this break compatibilty with the docker journald log driver (on which this behavior was based) |
True. I can try to add a switch. But I'd also need to make changes to podman then ( |
yeah I think that'd be best |
tobwen
changed the title
|
Implementation is too complicated and the audience is too little. Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
summary
When writing logs from conmon into journald and post-process the journal with rsyslog or others, there's no way to filter logs from plain syslog messages. This PR prefixes the container's name and its tags (if set) to each message. See: #271
syntax
container-name[container-tag]examples
container-name has been set, container-tag has been set
Jun 7 00:00:00 debian conmon[666]: podman-nginx[test-buid-20210706] messageonly container-name has been set
Jun 7 00:00:00 debian conmon[667]: podman-nginx It works.only container-tag has been set
Jun 7 00:00:00 debian conmon[668]: [test-buid-20210706] It works.neither ... nor ... has been set
Jun 7 00:00:00 debian conmon[669]: It works.