Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pyproject toml and enable workflow for publishing on PyPI #480

Merged
merged 4 commits into from
Feb 7, 2025

Conversation

inknos
Copy link
Contributor

@inknos inknos commented Dec 11, 2024

This PR incorporates all the building tools in pyproject.toml while keeping most of the changes in the

It also proposes to auto-build pushes and publish signed artifacts on PyPI testing. The process also automates tagged commits publishing to PyPI.

Publishing on PyPI follows this guide

Requires: #476

@inknos inknos mentioned this pull request Dec 10, 2024
22 tasks
@inknos inknos changed the title Use pyproject toml and enable workflow for publishing on PyPI [wip] Use pyproject toml and enable workflow for publishing on PyPI Dec 11, 2024
@inknos inknos force-pushed the use-pyproject-toml branch from 92e8d38 to 81bf1b5 Compare December 11, 2024 15:46
@inknos inknos force-pushed the use-pyproject-toml branch from 81bf1b5 to 7e29630 Compare December 11, 2024 15:47
@inknos inknos force-pushed the use-pyproject-toml branch 3 times, most recently from c26888d to 257b46a Compare December 11, 2024 16:16
@inknos
Copy link
Contributor Author

inknos commented Dec 11, 2024

Some errors from building python-podman might go away if we rebase onto #476 as typing_extensions.py is going away.

So I am trying to rebase onto these commits now although the only important ones are the last two at the moment

@inknos inknos force-pushed the use-pyproject-toml branch 2 times, most recently from dcf1909 to 309c0ca Compare December 11, 2024 16:51
@rhatdan
Copy link
Member

rhatdan commented Jan 23, 2025

@inknos still working on this?

@inknos
Copy link
Contributor Author

inknos commented Jan 24, 2025

yes, waiting on #476 to be merged first

@inknos inknos force-pushed the use-pyproject-toml branch from 309c0ca to 5603867 Compare January 30, 2025 15:02
@inknos inknos changed the title [wip] Use pyproject toml and enable workflow for publishing on PyPI Use pyproject toml and enable workflow for publishing on PyPI Jan 30, 2025
@inknos inknos force-pushed the use-pyproject-toml branch from 5603867 to ca51d7a Compare January 30, 2025 15:06
@inknos inknos marked this pull request as ready for review January 30, 2025 15:07
Fix errors for tyope annotation for list, dict, type and tuple

Example:
UP006: Use `list` instead of `List` for type annotation

Signed-off-by: Nicola Sella <[email protected]>
@inknos inknos force-pushed the use-pyproject-toml branch 3 times, most recently from 4e5da81 to 6d66eaa Compare January 30, 2025 16:24
@inknos inknos force-pushed the use-pyproject-toml branch from 6380998 to 6d66eaa Compare January 30, 2025 16:31
@inknos
Copy link
Contributor Author

inknos commented Jan 30, 2025

I am investigating why the package python3-podman+progress_bar now gives troubles in centos-stream9 and epel9... It shouldn't change how the provides are set in the specfile by the macro %pyproject_extras_subpkg, but apparently something's not right

@inknos inknos force-pushed the use-pyproject-toml branch from 6d66eaa to 0ba67f9 Compare February 3, 2025 14:26
@rhatdan
Copy link
Member

rhatdan commented Feb 4, 2025

LGTM
@jwhonce @umohnani8 PTAL

@inknos
Copy link
Contributor Author

inknos commented Feb 4, 2025

a bit of tweaking is still required as builds for centos9 and epel9 are currently failing, but I identified the issue

Signed-off-by: Nicola Sella <[email protected]>
Signed-off-by: Nicola Sella <[email protected]>
@inknos inknos force-pushed the use-pyproject-toml branch from 0ba67f9 to 945693b Compare February 5, 2025 14:05
@inknos
Copy link
Contributor Author

inknos commented Feb 6, 2025

  • Fedora 42 builds are ok again.
  • One test failed but I think it's flaky. I re-issued a run

@jwhonce I think we are good after the tests pass

@jwhonce
Copy link
Member

jwhonce commented Feb 6, 2025

LGTM

@lsm5 PTAL Thanks

@jwhonce jwhonce requested a review from lsm5 February 6, 2025 21:57
Copy link
Member

@lsm5 lsm5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't understand this much TBH, and IIUC we'll see the results of GHA only after a new release is created .

Everything's green so LGTM.

Copy link
Contributor

openshift-ci bot commented Feb 7, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: inknos, jwhonce, lsm5

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [inknos,jwhonce,lsm5]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@lsm5
Copy link
Member

lsm5 commented Feb 7, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Feb 7, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit aba801a into containers:main Feb 7, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants