New VMs: test crun 1.17 #23937
Merged
New VMs: test crun 1.17 #23937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: edsantiago The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
edsantiago
force-pushed
the
test-crun-17
branch
2 times, most recently
from
71ab74c
to
8d45302
Compare
edsantiago
changed the title
edsantiago
force-pushed
the
test-crun-17
branch
from
8d45302
to
dcb4fc9
Compare
|
LGTM |
...and remove one old skip() for older debian, but leave two others in place and mark that they're still a problem. Signed-off-by: Ed Santiago <[email protected]>
edsantiago
force-pushed
the
test-crun-17
branch
from
dcb4fc9
to
8d119f0
Compare
|
I was mistaken: the |
|
@containers/podman-maintainers PTAL |
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...and remove a bunch of old skip()s for older debian
Do not merge, because crun-1.17 seems broken (containers/crun#1560)That bug is not new in 1.17.Signed-off-by: Ed Santiago [email protected]