-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a test for forcing compression and v2s2 format #24673
base: main
Are you sure you want to change the base?
Conversation
ccf7160
to
71c9623
Compare
71c9623
to
d16d868
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Jamstah The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @mtrmac
6871b47
to
5563a32
Compare
Cockpit tests failed for commit 6871b47. @martinpitt, @jelly, @mvollmer please check. |
Cockpit tests failed for commit 5563a32. @martinpitt, @jelly, @mvollmer please check. |
Wrt. failed cockpit rawhide test: I reported the criu/kernel regression to https://bugzilla.redhat.com/show_bug.cgi?id=2328985 and silenced it in our tests in cockpit-project/bots#7146 . From now on, this failure will be ignored, i.e. tests should go back to green. Please either retry or re-push. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! ACK to the goal and overall approach.
For the record, this PR exists to test containers/common#2255 . |
5563a32
to
636b09e
Compare
This highlights a bug in common where the compression format is reset if the format is v2s2, even if its a valid compression format. Signed-off-by: James Hewitt <[email protected]>
Ephemeral COPR build failed. @containers/packit-build please check. |
636b09e
to
d2ae359
Compare
d2ae359
to
46066cc
Compare
Signed-off-by: James Hewitt <[email protected]>
46066cc
to
6f0a45d
Compare
This highlights a bug in common where the compression format is reset if the format is v2s2, even if its a valid compression format.
Does this PR introduce a user-facing change?