Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a test for forcing compression and v2s2 format #24673

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Jamstah
Copy link

@Jamstah Jamstah commented Nov 25, 2024

This highlights a bug in common where the compression format is reset if the format is v2s2, even if its a valid compression format.

Does this PR introduce a user-facing change?

None

@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none labels Nov 25, 2024
@Jamstah Jamstah force-pushed the allow-forced-gzip-on-v2s2 branch 2 times, most recently from ccf7160 to 71c9623 Compare November 25, 2024 17:32
Copy link
Contributor

openshift-ci bot commented Nov 25, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Jamstah
Once this PR has been reviewed and has the lgtm label, please assign tomsweeneyredhat for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @mtrmac

test/e2e/push_test.go Outdated Show resolved Hide resolved
test/e2e/push_test.go Show resolved Hide resolved
@Jamstah Jamstah force-pushed the allow-forced-gzip-on-v2s2 branch 2 times, most recently from 6871b47 to 5563a32 Compare November 26, 2024 13:25
Copy link

Cockpit tests failed for commit 6871b47. @martinpitt, @jelly, @mvollmer please check.

Copy link

Cockpit tests failed for commit 5563a32. @martinpitt, @jelly, @mvollmer please check.

@martinpitt
Copy link
Contributor

Wrt. failed cockpit rawhide test: I reported the criu/kernel regression to https://bugzilla.redhat.com/show_bug.cgi?id=2328985 and silenced it in our tests in cockpit-project/bots#7146 . From now on, this failure will be ignored, i.e. tests should go back to green. Please either retry or re-push.

Copy link
Collaborator

@mtrmac mtrmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! ACK to the goal and overall approach.

test/e2e/push_test.go Show resolved Hide resolved
test/e2e/push_test.go Show resolved Hide resolved
@mtrmac
Copy link
Collaborator

mtrmac commented Nov 26, 2024

For the record, this PR exists to test containers/common#2255 .

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 27, 2024
This highlights a bug in common where the compression format is reset if the format is v2s2, even if its a valid compression format.

Signed-off-by: James Hewitt <[email protected]>
Copy link

Ephemeral COPR build failed. @containers/packit-build please check.

@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants