-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump to v0.1.3 #479
Bump to v0.1.3 #479
Conversation
Signed-off-by: Daniel J Walsh <[email protected]>
Reviewer's Guide by SourceryThis is a version bump PR that updates the package version from 0.1.2 to 0.1.3 across multiple configuration files. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @rhatdan - I've reviewed your changes - here's some feedback:
Overall Comments:
- Missing comma after version number in setup.py - please add it back to maintain consistent style
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
setup.py
Outdated
@@ -63,7 +63,7 @@ def find_package_modules(self, package, package_dir): | |||
|
|||
setuptools.setup( | |||
name="ramalama", | |||
version="0.1.2", | |||
version="0.1.3" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
issue (bug_risk): Missing comma after version string
This will cause a syntax error in setup.py. A comma is needed after the version string to properly separate the dictionary items.
Signed-off-by: Daniel J Walsh <[email protected]>
Summary by Sourcery
Chores: