Add width/height attributes to the picture source #2811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This will also need to be adjusted in |
m-vo
reviewed
Feb 26, 2021
core-bundle/src/Resources/contao/templates/picture/picture_default.html5
Show resolved
Hide resolved
|
Chrome 90 is released, so I think we can merge this. 🎉 |
fritzmg
approved these changes
Apr 29, 2021
Toflar
approved these changes
Apr 29, 2021
m-vo
requested changes
Apr 29, 2021
Another one I think because this one is for version 4.9. |
|
PR for Contao 4.11: #2982 |
leofeyer
changed the title
|
Thank you @ausi. |
bezin
pushed a commit
to bezin/contao
that referenced
this pull request
Nov 26, 2021
Description ----------- | Q | A | -----------------| --- | Fixed issues | Fixes contao#2746 We should probably wait for Chrome 90 to be released on April 13th before merging this. https://chromestatus.com/feature/5737185317748736 UPDATE: Implementation tickets for Safari and Firefox: - <https://bugzilla.mozilla.org/show_bug.cgi?id=1694741> - <https://bugs.webkit.org/show_bug.cgi?id=222368> Commits ------- 1c07def Set picture source width/height attributes fc2006a Merge branch '4.9' into fix/picture-source-width-height 328b867 Merge branch '4.9' into fix/picture-source-width-height
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should probably wait for Chrome 90 to be released on April 13th before merging this. https://chromestatus.com/feature/5737185317748736
UPDATE: Implementation tickets for Safari and Firefox: