Set img width/height attributes as an aspect ratio #940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leofeyer
reviewed
Nov 7, 2019
core-bundle/src/Resources/contao/templates/picture/picture_default.html5
Outdated
Show resolved
Hide resolved
leofeyer
changed the title
Firefox 71 has been released. Do you want me to merge now? |
|
The |
ausi
force-pushed
the
bugfix/img-width-height-aspect-ratio-4-4
branch
from
d1d4545
to
4560027
Compare
Toflar
previously approved these changes
Dec 7, 2019
leofeyer
approved these changes
Dec 9, 2019
|
Thank you @ausi. |
ausi
commented
Dec 10, 2019
| @@ -31,6 +31,8 @@ | |||
| */ | |||
| class PictureFactory implements PictureFactoryInterface | |||
| { | |||
| const ASPECT_RATIO_THRESHOLD = 0.05; | |||
There was a problem hiding this comment.
@leofeyer can we mark this as private when merging upstream?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #937