Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bilal/list support #13

Open
wants to merge 23 commits into
base: develop
Choose a base branch
from
Open

Bilal/list support #13

wants to merge 23 commits into from

Conversation

Billalkhn
Copy link
Contributor

  • Bullet and Number Listing Feature Add.
  • Serialization ad deserialization updated.
  • Hotkeys For Bold, italic, underline, and code Added.

@Billalkhn Billalkhn requested a review from Hamzaalam November 30, 2020 21:07
Copy link
Collaborator

@Hamzaalam Hamzaalam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Billalkhn please look up on the build issues on this PR
image

@@ -0,0 +1 @@
[1130/192337.441:ERROR:directory_reader_win.cc(43)] FindFirstFile: The system cannot find the path specified. (0x3)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be removed.

Comment on lines +2 to +6
'mod+b': 'bold',
'mod+i': 'italic',
'mod+u': 'underlined',
'mod+`': 'code',
};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good.

@Fahad-Mahmood
Copy link
Member

there should be a way to close a list if enter key is pressed and current list-item text is empty, instead of going to toolbar every time.

@Hamzaalam
Copy link
Collaborator

there should be a way to close a list if enter key is pressed and current list-item text is empty, instead of going to toolbar every time.

I think we can close on enter and append it on shift + enter

@Billalkhn
Copy link
Contributor Author

there should be a way to close a list if enter key is pressed and current list-item text is empty, instead of going to toolbar every time.

I think we can close on enter and append it on shift + enter

Yes we can do this @Hamzaalam

@Hamzaalam
Copy link
Collaborator

@Billalkhn can you do something about this PR ? we don't need a listing feature on priority as PR not merged because of some listing issues but we need Hotkeys For Bold, italic, underline, and code Added which can be extracted and merged as a new PR.
what do you think ?

@Billalkhn
Copy link
Contributor Author

Billalkhn commented Jan 21, 2021 via email

@Hamzaalam
Copy link
Collaborator

I think we should to fix listing issue as well and merged this branch cuz listing feature and hotkeys features has been almost completed just need to fix minor issues.

On Thu, 21 Jan 2021, 3:41 pm Hamza Alam, @.***> wrote: @Billalkhn https://github.com/Billalkhn can you do something about this PR ? we don't need a listing feature on priority as PR not merged because of some listing issues but we need Hotkeys For Bold, italic, underline, and code Added which can be extracted and merged as a new PR. what do you think ? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#13 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMG6SETPQVUFKZP2U6IDNWDS3AAERANCNFSM4UIDK2FA .

that will be great 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants