-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(#145): ManifestSummary/Tooltip/Popover accessibility #146
base: main
Are you sure you want to change the base?
Conversation
Tooltip component used in ManifestSummary should: 1. Trigger should be keyboard accessible as a button. 2. Trigger should be labeled by the Tooltip and the header. 3. Popover for Tooltip should expand on focus and close on blur. 4. Popover should hide with Escape key and toggle on Trigger click. 5. Fix text color contrast for --cai-secondary-color. 6. Fix color contrast for --cai-icon-fill 7. Add focus outline color and outline-offset to Tooltip button and View More 8. Use `<section>` with aria-labelledby for PanelSection. 9. Add role="heading" and a heading level for the .heading-text element within PanelSection 10. Add role="img" and appropriate aria-label for each of the Icons
Thank you @majornista - we were working on updates to the ManifestSummary during the initial PR, and I see that you have updated |
Implement keyboard accessibility for Popover trigger and make it more generic, so that a user only needs to worry about an aria-label for the cai-indicator, rather than the expand/collapse behavior as well.
@dkozma and @emensch Can we please get a review of this PR? It is a blocker for making the content credentials popover accessible. A particular concern is the DOM order of the trigger versus the content: d6f2741#diff-0af38510afd0ed067e98bb00486befb58e93e539b3d6070dff1fd2d2ae12874fL392-L420 |
Bump! |
Changes in this pull request
Tooltip component used in ManifestSummary should:
<section>
with aria-labelledby for PanelSection.Types of changes
Checklist
TO DO
items (or similar) have been entered as GitHub issues and the link to that issue has been included in a comment