Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#145): ManifestSummary/Tooltip/Popover accessibility #146

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

majornista
Copy link

Changes in this pull request

Tooltip component used in ManifestSummary should:

  1. Trigger should be keyboard accessible as a button.
  2. Trigger should be labeled by the Tooltip and the header.
  3. Popover for Tooltip should expand on focus and close on blur.
  4. Popover should hide with Escape key and toggle on Trigger click.
  5. Fix text color contrast for --cai-secondary-color.
  6. Fix color contrast for --cai-icon-fill
  7. Add focus outline color and outline-offset to Tooltip button and View More
  8. Use <section> with aria-labelledby for PanelSection.
  9. Add role="heading" and a heading level for the .heading-text element within PanelSection
  10. Add role="img" and appropriate aria-label for each of the Icons

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • All applicable changes have been documented
  • Any TO DO items (or similar) have been entered as GitHub issues and the link to that issue has been included in a comment

majornista and others added 2 commits March 5, 2024 17:35
Tooltip component used in ManifestSummary should:

1. Trigger should be keyboard accessible as a button.
2. Trigger should be labeled by the Tooltip and the header.
3. Popover for Tooltip should expand on focus and close on blur.
4. Popover should hide with Escape key and toggle on Trigger click.
5. Fix text color contrast for --cai-secondary-color.
6. Fix color contrast for  --cai-icon-fill
7. Add focus outline color and outline-offset to Tooltip button and View More
8. Use `<section>` with aria-labelledby for PanelSection.
9. Add role="heading" and a heading level for the .heading-text element within PanelSection
10. Add role="img" and appropriate aria-label for each of the Icons
@dkozma dkozma requested a review from emensch March 27, 2024 14:19
@dkozma
Copy link

dkozma commented Mar 27, 2024

Thank you @majornista - we were working on updates to the ManifestSummary during the initial PR, and I see that you have updated main. We will take a look into getting this in this sprint.

majornista and others added 5 commits May 2, 2024 14:55
Implement keyboard accessibility for Popover trigger and make it more generic, so that a user only needs to worry about an aria-label for the cai-indicator, rather than the expand/collapse behavior as well.
@majornista
Copy link
Author

@dkozma and @emensch Can we please get a review of this PR? It is a blocker for making the content credentials popover accessible. A particular concern is the DOM order of the trigger versus the content:

d6f2741#diff-0af38510afd0ed067e98bb00486befb58e93e539b3d6070dff1fd2d2ae12874fL392-L420

@majornista
Copy link
Author

@dkozma and @emensch Can we please get a review of this PR? It is a blocker for making the content credentials popover accessible. A particular concern is the DOM order of the trigger versus the content:

d6f2741#diff-0af38510afd0ed067e98bb00486befb58e93e539b3d6070dff1fd2d2ae12874fL392-L420

Bump!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants