Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Run formatter on all the python files #75

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

gpeacock
Copy link
Contributor

@gpeacock gpeacock commented Dec 3, 2024

Also removes file close warnings in tests.

@gpeacock gpeacock requested review from dyro and tmathern and removed request for tmathern December 3, 2024 19:26
Copy link
Collaborator

@tmathern tmathern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not going to argue with a formatter

load_settings_file,
)
from .c2pa import Error, SigningAlg, CallbackSigner, sdk_version, version, load_settings
from .c2pa.c2pa import (
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I never saw the syntax with parenthesis before, hope it doesn't have adverse strange side-effects. After researching it, that's allowed only for Python 3.10 and later, so Python-wise should be fine.

@@ -102,6 +107,14 @@ impl Reader {
}
}

// pub fn validation_state(&self) -> Result<ValidationState> {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it debug code?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants