Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on named-regexp #297

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cushon
Copy link

@cushon cushon commented Jan 18, 2024

named-regexp is a backport of named capture groups, which were introduced in Java 7. This library targets Java 8, so the backport is unnecessary.

See tony19/named-regexp#73 (comment)

named-regexp is a backport of named capture groups, which were
introduced in Java 7. This library targets Java 8, so the backport is
unnecessary.

See tony19/named-regexp#73 (comment)
@tony19
Copy link

tony19 commented Jan 20, 2024

Looks like named-regexp was added in #215 to fix #204 a bug for Android API <26. If Contentful actually needs to continue using named-regexp, please upgrade to v1.0.0 to workaround the build problem with JDK 20+.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants