feat: support react 19 #983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YvesRijckaert
force-pushed
the
feat/support-react-19
branch
from
70c12a2 to
5d89acb
Compare
YvesRijckaert
force-pushed
the
feat/support-react-19
branch
from
5d89acb to
a17236f
Compare
chrishelgert
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Second attempt to support react 19 and Next 15. The previous PR (#980) caused issues in projects using Next.js 14. The following issue appeared:
The current build config only marks 'react' as external, but now we also mark the other React submodules.
Fixes: #778
Testing