Merge pull request #1578 from contentstack/fix/staging

fixed regex dos issue in variants message
contentstack · Sep 23, 2024 · c518bce · c518bce
2 parents 2a4ebf5 + e22db80
commit c518bce
Show file tree

Hide file tree

Showing 3 changed files with 245 additions and 236 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/packages/contentstack-variants/src/messages/index.ts b/packages/contentstack-variants/src/messages/index.ts
@@ -50,7 +50,8 @@ function $t(msg: string, args: Record<string, string>): string {
 
     for (const key of Object.keys(args)) {
       const escapedKey = key.replace(/[.*+?^${}()|[\]\\]/g, '\\$&');
-      msg = msg.replace(new RegExp(`{${escapedKey}}`, 'g'), args[key] || escapedKey);
+      const placeholder = `{${escapedKey}}`;
+      msg = msg.split(placeholder).join(args[key]);
     }
 
     return msg;