CS-42935/feat-taxonomy-and-eah #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ishaileshmishra
commented
Dec 13, 2023
ishaileshmishra
commented
- Taxonomy query support added
- Early Access Feature Support
nadeem-cs
requested changes
Dec 15, 2023
| @@ -26,6 +26,8 @@ public class Constants { | |||
| protected static final String CONTENT_TYPE_UID = "content_type_uid"; | |||
| protected static final String ENTRY_UID = "entry_uid"; | |||
| protected static final String LIVE_PREVIEW = "live_preview"; | |||
|
|
|||
| protected static final String TaxonomyPath = "/taxonomies/entries?query"; | |||
There was a problem hiding this comment.
Change this to all UPPERCASE with an underscore separating the words as per the naming conventions for constants. @ishaileshmishra
| @@ -14,16 +14,14 @@ class TestAsset { | |||
| private String assetUid; | |||
| private final Stack stack = Credentials.getStack(); | |||
|
|
|||
| private String envChecker() { | |||
| private void envChecker() { | |||
| String githubActions = System.getenv("GITHUB_ACTIONS"); | |||
| if (githubActions != null && githubActions.equals("true")) { | |||
| System.out.println("Tests are running in GitHub Actions environment."); | |||
| String mySecretKey = System.getenv("API_KEY"); | |||
| System.out.println("My Secret Key: " + mySecretKey); | |||
There was a problem hiding this comment.
Why are we logging the API_KEY here? @ishaileshmishra
| @@ -65,7 +64,7 @@ private Credentials() throws AccessException { | |||
| public static Stack getStack() { | |||
| if (stack == null) { | |||
| var envCheck = envChecker(); | |||
| System.out.println(envCheck); | |||
| System.out.println("idendified env file detected " + envCheck); | |||
There was a problem hiding this comment.
Why are we logging the env here? @ishaileshmishra
|
Thanks for identifying the issues @nadeem-cs , I have made required changes. Please review again |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.