Merge pull request #60 from contentstack/RT-334

feat: add quotes for inline properties
contentstack · Oct 24, 2024 · 25f73c6 · 25f73c6
2 parents 1936865 + bbcce97
commit 25f73c6
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/src/toRedactor.tsx b/src/toRedactor.tsx
@@ -225,13 +225,13 @@ export const toRedactor = (jsonValue: any,options?:IJsonToHtmlOptions) : string
     }
     if(jsonValue['classname'] || jsonValue['id']){
       if(jsonValue['classname'] && jsonValue['id']){
-        text = `<span class=${jsonValue['classname']} id=${jsonValue['id']}>${text}</span>`
+        text = `<span class="${jsonValue['classname']}" id="${jsonValue['id']}">${text}</span>`
       }
       else if(jsonValue['classname'] && !jsonValue['id']){
-        text = `<span class=${jsonValue['classname']}>${text}</span>`
+        text = `<span class="${jsonValue['classname']}">${text}</span>`
       }
       else if(jsonValue['id'] && !jsonValue['classname']){
-        text = `<span id=${jsonValue['id']}>${text}</span>`
+        text = `<span id="${jsonValue['id']}">${text}</span>`
       }
     }
     if (jsonValue.text.includes('\n') && !jsonValue['break']) {

diff --git a/test/expectedJson.ts b/test/expectedJson.ts
@@ -1717,7 +1717,7 @@ export default {
         ]
     },
     "inline-classname-and-id": {
-        "html": '<p><span>This is test for adding inline <span class=class>class</span> and <span id=id>id</span></span></p>',
+        "html": '<p><span>This is test for adding inline <span class="class">class</span> and <span id="id">id</span></span></p>',
         "json": [
                     {
                         "type": "p",