Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EB-1200: Implement signals in live preview sdk #111

Merged
merged 10 commits into from
Mar 12, 2024
Merged

EB-1200: Implement signals in live preview sdk #111

merged 10 commits into from
Mar 12, 2024

Conversation

Vishvam10
Copy link
Contributor

Jira Story

Work has been completed on this Jira story : https://contentstack.atlassian.net/browse/EB-1200

Overview

This PR focuses on integrating DeepSignal package into existing codebase and refactoring the Config object to make it reactive. This will make things easier in the future (say if we want to subscribe to a property, etc) and also improves the DX.

Changes Made

  • Installed and configured DeepSignal package, a re-implementation of Preact Signals using JS Proxies
  • Updated all the static methods of the Config object
  • Refactored all Config related code to incorporate DeepSignal
  • Re-wrote and corrected broken test cases related to the Config object

@Vishvam10 Vishvam10 added the enhancement New feature or request label Mar 11, 2024
@Vishvam10 Vishvam10 requested a review from Deepak-Kharah March 11, 2024 12:53
@Vishvam10 Vishvam10 self-assigned this Mar 11, 2024
@Vishvam10 Vishvam10 requested a review from a team as a code owner March 11, 2024 12:53
Deepak-Kharah
Deepak-Kharah requested changes Mar 11, 2024
View reviewed changes
src/configManager/__test__/handleUserConfig.test.ts Outdated Show resolved Hide resolved
src/livePreview/editButton/editButton.ts Outdated Show resolved Hide resolved
src/livePreview/eventManager/postMessageEvent.hooks.ts Outdated Show resolved Hide resolved
@Vishvam10 Vishvam10 requested a review from Deepak-Kharah March 12, 2024 06:09
@Vishvam10 Vishvam10 merged commit 373761f into VC-115/live-editor-support Mar 12, 2024
3 checks passed
@aravindbuilt aravindbuilt deleted the EB-1200-implement-signals-in-live-preview-sdk branch January 15, 2025 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Deepak-Kharah Deepak-Kharah Deepak-Kharah approved these changes

Assignees

@Vishvam10 Vishvam10

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Vishvam10 @Deepak-Kharah