Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support to live sync form on inline editing #279

Merged
merged 1 commit into from
Oct 25, 2024
Merged

feat: add support to live sync form on inline editing #279

merged 1 commit into from
Oct 25, 2024

Conversation

hiteshshetty-dev
Copy link
Contributor

No description provided.

@hiteshshetty-dev hiteshshetty-dev requested a review from a team as a code owner October 25, 2024 06:56
@github-actions GitHub Actions
Copy link

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 47.61% 5999 / 12598
🔵 Statements 47.61% 5999 / 12598
🔵 Functions 69.75% 203 / 291
🔵 Branches 81.42% 618 / 759
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
src/visualBuilder/generators/generateOverlay.tsx 99.43% 89.47% 100% 99.43% 159
src/visualBuilder/utils/handleFieldMouseDown.ts 68.88% 86.66% 50% 68.88% 12-20, 22-33, 46-47, 50-54
src/visualBuilder/utils/types/postMessage.types.ts 100% 100% 100% 100%
Generated in workflow #98 for commit 2558f02 by the Vitest Coverage Report Action

faraazb
faraazb approved these changes Oct 25, 2024
View reviewed changes
Copy link
Contributor

@faraazb faraazb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hiteshshetty-dev hiteshshetty-dev merged commit ca4eb5f into VC-115/live-editor-support Oct 25, 2024
6 checks passed
@aravindbuilt aravindbuilt deleted the VE-3825 branch January 15, 2025 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@faraazb faraazb faraazb approved these changes

@csAyushDubey csAyushDubey Awaiting requested review from csAyushDubey

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hiteshshetty-dev @faraazb