Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(VE-5055): add validations in textarea #347

Merged
merged 2 commits into from
Feb 6, 2025
Merged

fix(VE-5055): add validations in textarea #347

merged 2 commits into from
Feb 6, 2025

Conversation

pratyushbiswas
Copy link

No description provided.

@pratyushbiswas pratyushbiswas requested a review from a team as a code owner February 6, 2025 08:36
@pratyushbiswas pratyushbiswas changed the title fix(chore): add validations in textarea fix(VE-5055): add validations in textarea Feb 6, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 6, 2025 •
edited
Loading

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 70.45% 7155 / 10155
🔵 Statements 70.45% 7155 / 10155
🔵 Functions 71.34% 254 / 356
🔵 Branches 83.75% 804 / 960
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
src/visualBuilder/components/Collab/ThreadPopup/CommentTextArea.tsx 9.95% 100% 100% 9.95% 45-282
src/visualBuilder/components/Collab/ThreadPopup/ThreadFooter.tsx 17.02% 100% 0% 17.02% 17-60
src/visualBuilder/utils/collabUtils.ts 75.64% 100% 77.77% 75.64% 82-101, 109-110
Generated in workflow #219 for commit f334d7d by the Vitest Coverage Report Action

@Zuhair2002 Zuhair2002 self-requested a review February 6, 2025 08:49
Zuhair2002
Zuhair2002 approved these changes Feb 6, 2025
View reviewed changes
Copy link

@Zuhair2002 Zuhair2002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pratyushbiswas pratyushbiswas merged commit 595b2ed into collab Feb 6, 2025
6 checks passed
@pratyushbiswas pratyushbiswas deleted the VE-5055-disable-post-submission branch February 6, 2025 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zuhair2002 Zuhair2002 Zuhair2002 approved these changes

Assignees

@pratyushbiswas pratyushbiswas

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pratyushbiswas @Zuhair2002