Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update field adds <div/> element #91

Merged

Conversation

Deepak-Kharah
Copy link
Contributor

We were adding inner HTML that adds the inline div elements. We replaced it with innerText if available as it retains the \n. However, if it is not available we fallback to text content.

fixes: https://contentstack.atlassian.net/browse/EB-817

We were adding inner HTML that adds the inline div elements. We replaced
it with innerText if available as it retains the `\n`. However, if it is not available
we fallback to text content.

fixes: https://contentstack.atlassian.net/browse/EB-817
@Deepak-Kharah Deepak-Kharah requested a review from a team as a code owner January 10, 2024 11:52
Copy link
Contributor

@RavenColEvol RavenColEvol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM // approved in Slack with WorkerB

@Deepak-Kharah Deepak-Kharah merged commit 9b9984f into VC-115/live-editor-support Jan 10, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants