Handle message during tool call #4692
Draft
+126
−144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for continuedev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
sestinj
approved these changes
Mar 17, 2025
|
@RomneyDa I performed a number of tests with this change using both the Bedrock Claude 3.5 and 3.7 models and performaed a number of steps where I cancelled the tools use, and switched directions or then restarted without finding any issues. This is a really great change and a common complaint from our users given to escape from this situation they have to start a new context today. Recommend we merge this as soon as possible. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If user sends message during tool call (especially during asking permission), send a tool response notifying that the user cancelled the tool call, and then move forward like a normal message
This PR also removes the
gatherContextthunk and moves the once-used logic into the streamResponse thunk, in part because it would be nice to move towards no/less thunksTODO change the approach here - should prob inject a tool response message not a tool response AND user message