Add new functions for faster permissions setting #332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
kierenevans
commented
Jul 24, 2017
kierenevans
commented
- Add common methods to set permissions so we can extend it in the future to include setfacl if possible.
- Use find to speed up permissions setting by finding files and directories not owned by the right user/group or not the right permissions - this helps a lot when using volumes!
andytson-inviqa
added a commit
that referenced
this pull request
Aug 23, 2017
Assumes for facl/stickybit that all users are umask 0002 It doesn't have the performance improvements of #332 yet, though I'm unsure if that's possible with setfacl
andytson-inviqa
added a commit
that referenced
this pull request
Aug 23, 2017
Assumes for facl/stickybit that all users are umask 0002 It doesn't have the performance improvements of #332 yet, though I'm unsure if that's possible with setfacl
|
That's a very good idea! What's blocking this PR? |
kierenevans
pushed a commit
that referenced
this pull request
Sep 14, 2017
Assumes for facl/stickybit that all users are umask 0002 It doesn't have the performance improvements of #332 yet, though I'm unsure if that's possible with setfacl
kierenevans
commented
Sep 20, 2017
| if [ "$IS_CHOWN_FORBIDDEN" != 'true' ]; then | ||
| find "${OWNERSHIP_PATH[@]}" \( ! -user "${USER}" -or ! -group "${GROUP}" \) -exec chown "${USER}:${GROUP}" {} + | ||
| fi | ||
| do_read_write_permissions "${OWNERSHIP_PATH[@]}" "${ALLOW_GROUP_WRITE}" |
There was a problem hiding this comment.
This doesn't pass through the paths correctly to do_read_write_permissions, only the first one.
kierenevans
pushed a commit
that referenced
this pull request
Sep 25, 2017
Assumes for facl/stickybit that all users are umask 0002 It doesn't have the performance improvements of #332 yet, though I'm unsure if that's possible with setfacl
|
@kierenevans do you think you'd have some time at some point to go forward with this issue? Waiting a long time at every container start on the |
kierenevans
pushed a commit
that referenced
this pull request
Mar 17, 2018
Assumes for facl/stickybit that all users are umask 0002 It doesn't have the performance improvements of #332 yet, though I'm unsure if that's possible with setfacl
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.