Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix type error in str_replace in StringConfirmation of ColumnStatus/Option #1166

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix type error in str_replace in StringConfirmation of ColumnStatus/Option #1166

wants to merge 1 commit into from

Conversation

ikeblaster
Copy link
Contributor

PHP8+ will raise an error in case of a non-string column used for StringConfirmation in ColumnStatus Status\Option.

Error: str_replace(): Argument #2 ($replace) must be of type array|string, int given

Code to reproduce:

$grid->addColumnStatus('active', 'Stav')
     ->addOption('on', 'On')
     ->setConfirmation(new StringConfirmation('Enable "%s"?', 'number'));

Related issued #943 - fixed the same error in grid Actions.

@ikeblaster
Fix type error in str_replace in StringConfirmation of ColumnStatus/O…
143f972 
…ption

PHP8+ will raise an error in case of a non-string column used for StringConfirmation.

Error: str_replace(): Argument contributte#2 ($replace) must be of type array|string, int given
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ikeblaster