-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Functional constraints #123
Comments
If the other constraints! functions have no default values I suggest to change them as internal by writing __constraints!. Otherwise it may be confusing for the user. I am not sure I haven't looked closely the code. |
@ocots For now, I advocate keeping them to ensure compatibility with previous functional syntax.
|
@BaptisteCbl Hi! Just merged this (long pending) PR: thanks for the job. Will have soon a closer look at the resulting changes in the related branch. |
@jbcaillau have a look at #147 |
@BaptisteCbl Following comments in previous PR:
constraint!
(= the one with named args that factors out the code and is called by other / older versions without named args), we uselb/ub=Nothing
if no bound (instead of+/-[ Inf, ... ]
)constraint!
(= without named args) do not have any default values and call the previous one (no code duplication)When it is OK, can you please make a PR from your fork towards the
constraint_revise
branch?PS. I suspect that the new version will also solve [#122]
The text was updated successfully, but these errors were encountered: