Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Functional constraints #123

Closed
jbcaillau opened this issue Oct 20, 2023 · 4 comments
Closed

Functional constraints #123

jbcaillau opened this issue Oct 20, 2023 · 4 comments
Assignees

Comments

@jbcaillau
Copy link
Member

jbcaillau commented Oct 20, 2023

@BaptisteCbl Following comments in previous PR:

  • on the main version of constraint! (= the one with named args that factors out the code and is called by other / older versions without named args), we use lb/ub=Nothing if no bound (instead of +/-[ Inf, ... ])
  • all other versions of constraint! (= without named args) do not have any default values and call the previous one (no code duplication)

When it is OK, can you please make a PR from your fork towards the constraint_revise branch?

PS. I suspect that the new version will also solve [#122]

@jbcaillau jbcaillau changed the title foo Functional constraints Oct 20, 2023
@ocots
Copy link
Member

ocots commented Oct 22, 2023

If the other constraints! functions have no default values I suggest to change them as internal by writing __constraints!. Otherwise it may be confusing for the user.

I am not sure I haven't looked closely the code.

@jbcaillau
Copy link
Member Author

@ocots For now, I advocate keeping them to ensure compatibility with previous functional syntax.

If the other constraints! functions have no default values I suggest to change them as internal by writing __constraints!. Otherwise it may be confusing for the user.

I am not sure I haven't looked closely the code.

@jbcaillau
Copy link
Member Author

@BaptisteCbl Hi! Just merged this (long pending) PR: thanks for the job. Will have soon a closer look at the resulting changes in the related branch.

@ocots
Copy link
Member

ocots commented Jun 10, 2024

@jbcaillau have a look at #147

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants