-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP - add some boolean indicators for OCP #153
Changes from 6 commits
13822c7
0414e27
ea3be69
a6c87be
60143dd
782a2d9
a03c2e6
89f91e1
d800785
b3cc4ed
15f5c25
5a74f24
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I am wondering about consistency since it seems that the fields containing infos about dimensions and so the getters will return the right values only after the function
But I am not sure that this is the right thing to do. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @PierreMartinon I think you haven't reply to this comment. I think it is quite important. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @ocots Indeed I missed it. More precisely, the constraints dimensions are set in nlp_constraints since this is where the different kinds of constraints are parsed. Ideally, the various dimensions would be updated at each constraint! call, but I don't think it's worth the effort. These are pretty internal parameters, and are supposed to be called only after the ocp is fully defined. Maybe change the default value to -1 instead of 0 to make it more obvious ? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Edit: erf, -1 is not compatible with Dimension type. Just let it be ? If you prefer I will revert to dimensions internal to CTDirect |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would replace
OCPInit
byOptimalControlInit
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, done :D