Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add change of default AD backend #160

Merged
merged 5 commits into from
Jun 20, 2024
Merged

Add change of default AD backend #160

merged 5 commits into from
Jun 20, 2024

Conversation

ocots
Copy link
Member

@ocots ocots commented Jun 20, 2024

#25

@gdalle
Copy link
Contributor

gdalle commented Jun 20, 2024

My apologies but that's extremely ugly 🤣 why don't you just create a backend kwarg that gets passed all the way down from the user-facing functions / structs to the functions actually doing the differentiation?

@gdalle
Copy link
Contributor

gdalle commented Jun 20, 2024

Not to mention that you might need a combination of backends: you don't necessarily want to use the same backend for gradient and jacobian for example

src/default.jl Show resolved Hide resolved
@ocots ocots requested a review from jbcaillau June 20, 2024 21:30
@ocots ocots merged commit 7d7ce56 into main Jun 20, 2024
3 checks passed
@ocots ocots deleted the AD branch June 20, 2024 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants