Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update go to 1.23.1 for fixing High vulnerability #632

Merged
merged 2 commits into from
Oct 27, 2024

Conversation

jdesouza
Copy link
Contributor

@jdesouza jdesouza commented Sep 25, 2024

│ Library │ Vulnerability │ Severity │ Status │ Installed Version │ Fixed Version │ Title │
├─────────┼────────────────┼──────────┼────────┼───────────────────┼────────────────┼───────────────────────────────────────────────────────────┤
│ stdlib │ CVE-2024-34156 │ HIGH │ fixed │ 1.23.0 │ 1.22.7, 1.23.1 │ encoding/gob: golang: Calling Decoder.Decode on a message │
│ │ │ │ │ │ │ which contains deeply nested structures... │
│ │ │ │ │ │ │ https://avd.aquasec.com/nvd/cve-2024-34156

@jdesouza jdesouza changed the title Update go to 1.22.7 for fixing High vulnerability Update go to 1.23.1 for fixing High vulnerability Sep 25, 2024
@jdesouza
Copy link
Contributor Author

@06kellyjac would you mind taking a look at this PR?

@jdesouza
Copy link
Contributor Author

@sublimino any chance for reviewing this?

@sublimino
Copy link
Member

Thanks for the ping @jdesouza we'll test and release this 👍

@sublimino
Copy link
Member

Hi @jdesouza! We looked at this and GHSA-crqm-pwhx-j97f does not affect Kubesec according to govulncheck's analysis of the code:

image

We'll merge this anyway but we may wait to release, unless this is causing a specific issue?

@06kellyjac 06kellyjac merged commit 73faeb2 into controlplaneio:master Oct 27, 2024
10 checks passed
@jdesouza
Copy link
Contributor Author

Hi @jdesouza! We looked at this and GHSA-crqm-pwhx-j97f does not affect Kubesec according to govulncheck's analysis of the code:

image

We'll merge this anyway but we may wait to release, unless this is causing a specific issue?

We are getting the vuln reported by trivy

@06kellyjac
Copy link
Member

Thanks. Yeah I asked for the aqua team to integrate govulncheck a long while ago because you can end up with a lot of false positives importing x/net or anything kubernetes.

aquasecurity/trivy#2845

They said they're going to lean into VEX and that you should be able to generate a VEX output from govulncheck first and feed it into trivy (not always easy, I know)


Doing an upadte now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants