Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(config-lerna-scopes): remove deprecated @lerna/project dependency #4284

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

janbiasi
Copy link
Contributor

@janbiasi janbiasi commented Feb 16, 2025

Prerequisites

Description

Please see the long explanation in #4262

Motivation and Context

Usage examples

No changes

How Has This Been Tested?

Unit tests within the project

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

BREAKING CHANGE: drop support for lerna < 7.1.0
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@escapedcat
Copy link
Member

Is this a breaking change for anyone who is using lerna below v8?

@janbiasi
Copy link
Contributor Author

janbiasi commented Feb 18, 2025

Is this a breaking change for anyone who is using lerna below v8?

Yes, it will be a breaking change for lerna < 8.2.0 - I've added the necessary commit body in 22f0930

edit: sadly it's < 8.2.0 as the change within lerna was required

@janbiasi
Copy link
Contributor Author

@escapedcat By looking at the current config-pnpm-scopes implementation, I thought that I could copy it's implementation and adapt it to the lerna config schema. This way, we could support all lerna repositories which have the packages defined within lerna.json and wouldn't need to rely on the lerna package itself (= no breaking change). Additionally, we could implement an error if we detect no packages configuration and inform the user to use config-workspace-scopes in that case.

Would this be a better option? Let me know what you think.

@escapedcat
Copy link
Member

tbh I don't mind a breaking change. On the other hand it has 26k weekly downloads. So people might still use it with an older lerna version? If that's feasible and not too much work for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants