Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grammar cannot read git trailers #41

Open
epage opened this issue Oct 19, 2021 · 0 comments
Open

Grammar cannot read git trailers #41

epage opened this issue Oct 19, 2021 · 0 comments

Comments

@epage
Copy link

epage commented Oct 19, 2021

Compare

<footer>          ::= <token>, <separator>, <whitespace>*, <value>
/* "!" should be added to the AST as a <breaking-change> node with the value "!" */
<token>           ::= <breaking-change>
                   |  <type>, "(" <scope> ")", ["!"]
                   |  <type>, ["!"]
<separator>       ::= ":" | " #"
<value>           ::= <text>, <continuation>+
                   |  <text>
<continuation>    ::= <newline>, <whitespace>+, <text>

with https://git-scm.com/docs/git-interpret-trailers

  • "When reading trailers, there can be whitespaces after the token, the separator and the value"
  • "There can also be whitespaces inside the token and the value"
    • This one seems like it makes parsing trailers a lot harder and doesn't seem common
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant