fix(parser)!: Make footer parsing stricter #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epage
reviewed
Oct 17, 2022
src/commit.rs
Outdated
| @@ -187,7 +187,7 @@ impl<'a> Footer<'a> { | |||
| #[derive(Debug, Clone, Copy, Eq, PartialEq, Hash)] | |||
| #[non_exhaustive] | |||
| pub enum FooterSeparator { | |||
| /// ":" | |||
| /// ": " | |||
There was a problem hiding this comment.
We originally had this but it was changed in #18 as the grammer specifies the space is optional.
I raised conventional-commits/parser#41 but this is another issue in the grammar.
Would you be up for checking how the reference implementation handles this case?
There was a problem hiding this comment.
This seems tricky...I think I might not be up to the job 😥
There was a problem hiding this comment.
Mind at least creating an issue in this repo for discussing the state of this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, due to loose footer separator parsing,
https://xxxwas incorrectly parsed as a footer, so this PR fixed it.See: https://git-scm.com/docs/git-interpret-trailers#:~:text=This%20means%20that%20the%20trimmed%20%3Ctoken%3E%20and%20%3Cvalue%3E%20will%20be%20separated%20by%20%27%3A%20%27%20(one%20colon%20followed%20by%20one%20space).