Reject non-secure WebSocket or BOSH endpoints #3548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When discovering endpoints using XEP-0156, the server admin can list any kind of URL, but we want to use only secure ones using TLS. In order to achieve that, we filter out the lists before using the first one available. This was causing connection to fail with the step.im server, which exposes in order ws:, wss: and http:, and we were previously using only the first and third ones, instead of the second like we should. Should fix the issue reported by @vnpower at https://misskey.pm/notes/a0v0aaw0tbknyojk
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When discovering endpoints using XEP-0156, the server admin can list any kind of URL, but we want to use only secure ones using TLS. In order to achieve that, we filter out the lists before using the first one available.
This was causing connection to fail with the step.im server, which exposes in order ws:, wss: and http:, and we were previously using only the first and third ones, instead of the second like we should.
Should fix the issue reported by @vnpower at https://misskey.pm/notes/a0v0aaw0tbknyojk