- Add setContentView() use note to README.

- Moved `CustomFontCache.java` to util package.
cooldude77 · Oct 4, 2016 · 8249589 · 8249589
1 parent e36697c
commit 8249589
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 8 deletions.
diff --git a/README.md b/README.md
@@ -37,6 +37,8 @@ public class IntroActivity extends AppIntro {
     protected void onCreate(@Nullable Bundle savedInstanceState) {
         super.onCreate(savedInstanceState);
 
+        // Note here that we DO NOT use setContentView();
+
         // Add your slide fragments here.
         // AppIntro will automatically generate the dots indicator and buttons.
         addSlide(firstFragment);
@@ -83,6 +85,8 @@ public class IntroActivity extends AppIntro {
 }
 ```
 
+_Note above that we DID NOT use setContentView();_
+
 Finally, declare the activity in your Manifest like so:
 
 ``` xml
@@ -262,7 +266,7 @@ Do you need inspiration? A lot of apps are using AppIntro out there:
 <img src="https://github.com/PaoloRotolo/AppIntro/blob/master/art/Screenshot_2015-06-03-12-42-10.png" width="300">
 
 ## Apps using AppIntro
-If you are using AppIntro in your app and would like to be listed here, please let us know by opening a [new issue](https://github.com/PaoloRotolo/AppIntro/issues/new)!
+If you are using AppIntro in your app and would like to be listed here, please let us know by commenting in [this issue](https://github.com/PaoloRotolo/AppIntro/issues/325)!
 
  * [Numix Hermes](https://play.google.com/store/apps/details?id=org.numixproject.hermes)
  * [Audio Reminder Pro](https://play.google.com/store/apps/details?id=com.brandon.audioreminderpro)

diff --git a/library/src/main/java/com/github/paolorotolo/appintro/AppIntro.java b/library/src/main/java/com/github/paolorotolo/appintro/AppIntro.java
@@ -8,6 +8,7 @@
 import android.widget.LinearLayout;
 import android.widget.TextView;
 
+import com.github.paolorotolo.appintro.util.CustomFontCache;
 import com.github.paolorotolo.appintro.util.LogHelper;
 
 public abstract class AppIntro extends AppIntroBase {

diff --git a/library/src/main/java/com/github/paolorotolo/appintro/AppIntroBaseFragment.java b/library/src/main/java/com/github/paolorotolo/appintro/AppIntroBaseFragment.java
@@ -5,14 +5,14 @@
 import android.support.annotation.LayoutRes;
 import android.support.annotation.Nullable;
 import android.support.v4.app.Fragment;
-import android.support.v4.content.ContextCompat;
 import android.view.LayoutInflater;
 import android.view.View;
 import android.view.ViewGroup;
 import android.widget.ImageView;
 import android.widget.LinearLayout;
 import android.widget.TextView;
 
+import com.github.paolorotolo.appintro.util.CustomFontCache;
 import com.github.paolorotolo.appintro.util.LogHelper;
 
 public abstract class AppIntroBaseFragment extends Fragment implements ISlideSelectionListener,

diff --git a/...paolorotolo/appintro/CustomFontCache.java → ...rotolo/appintro/util/CustomFontCache.java b/...paolorotolo/appintro/CustomFontCache.java → ...rotolo/appintro/util/CustomFontCache.java
@@ -1,10 +1,8 @@
-package com.github.paolorotolo.appintro;
+package com.github.paolorotolo.appintro.util;
 
 import android.content.Context;
 import android.graphics.Typeface;
 
-import com.github.paolorotolo.appintro.util.LogHelper;
-
 import java.util.Hashtable;
 
 /**
@@ -28,16 +26,16 @@ public static Typeface get(String tfn, Context ctx) {
 
                 return tf;
             } catch (Exception e) {
-                if (tfn.equals("")){
+                if (("").equals(tfn)) {
                     LogHelper.w(TAG, e, "Empty path");
-                }else {
+                } else {
                     LogHelper.w(TAG, e, tfn);
                 }
+
                 return null;
             }
         } else {
             return tf;
         }
-
     }
 }