library_borrow: Fix proposition for is_available searchers and getters in Book and Exemplary #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s in Book and Exemplary
JCavallo
reviewed
Jan 17, 2025
modules/library_borrow/library.py
Outdated
| where=(checkout.return_date != Null) | (checkout.id == Null)) | ||
| return [('id', 'in' if value else 'not in', query)] | ||
| Book = Pool().get('library.book') | ||
| books = Book.search([]) |
There was a problem hiding this comment.
I think you are right, there may be a problem in this because an existing returned checkout will always match.
However, a search like this, while working, is not scalable in the real world, because you end up loading your whole database in a Python process.
|
Thanks a lot @JCavallo for your last comment ! So here is a new solution proposal for the 'searcher' and 'getter' taking in account your point. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix proposition #CCOOG-1198