Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][ADD] product_contract_storable #343

Open
wants to merge 1 commit into
base: 16.0
Choose a base branch
from
Open

[16.0][ADD] product_contract_storable #343

wants to merge 1 commit into from

Conversation

victor-champonnois
Copy link
Member

@victor-champonnois victor-champonnois commented Jan 8, 2025 •
edited
Loading

huguesdk
huguesdk requested changes Mar 14, 2025
View reviewed changes
Copy link
Member

@huguesdk huguesdk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the code looks ok, just some remarks about attribution.

product_contract_storable/readme/CONTRIBUTORS.rst Outdated
@@ -0,0 +1,3 @@
* `Coop IT Easy SC <https://coopiteasy.be>`_:

* hugues de keyzer
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i don’t remember working on this module. 😅 did i?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

product_contract_storable/views/product_template.xml Outdated
Comment on lines 3 to 5
Copyright 2017 LasLabs Inc.
Copyright 2018 ACSONE SA/NV.
License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this copyright correct?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@victor-champonnois victor-champonnois force-pushed the 16.0-product_contract_storable branch 2 times, most recently from 5f1e6a3 to 4c8827e Compare March 18, 2025 10:14
huguesdk
huguesdk approved these changes Mar 18, 2025
View reviewed changes
Copy link
Member

@huguesdk huguesdk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@huguesdk huguesdk force-pushed the 16.0-product_contract_storable branch from 4c8827e to 76d3d7d Compare March 18, 2025 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huguesdk huguesdk huguesdk approved these changes

Assignees
No one assigned
Labels
needs review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@victor-champonnois @huguesdk @github-grap-bot