[ADD] sepa_sale_order_autoconfirm #345
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
victor-champonnois
force-pushed
the
16.0-sepa_sale_order_autoconfirm
branch
from
fb7627e to
f32fadf
Compare
victor-champonnois
force-pushed
the
16.0-sepa_sale_order_autoconfirm
branch
from
f32fadf to
88667a7
Compare
|
@victor-champonnois Please, rebase here on 16.0 branch to clean tests. :) |
huguesdk
requested changes
Mar 19, 2025
| "license": "AGPL-3", | ||
| "depends": [ | ||
| "payment_sepa_dd", | ||
| ], |
There was a problem hiding this comment.
Suggested change
| ], | |
| "website_sale", | |
| ], |
There was a problem hiding this comment.
i think that this module should be named website_sale_order_sepa_autoconfirm.
Comment on lines
+9
to
+11
| website_sale = self.team_id == self.env.ref( | ||
| "sales_team.salesteam_website_sales" | ||
| ) |
There was a problem hiding this comment.
is this to detect whether this is done through the e-commerce? this seems a little dirty to me. isn’t there a cleaner way? like checking whether self.website_id is truthy?
| class SaleOrder(models.Model): | ||
| _inherit = "sale.order" | ||
|
|
||
| def action_quotation_sent(self): |
There was a problem hiding this comment.
this method needs a comment. when is this called and why is it this method that is overridden?
| ) | ||
| if website_sale and sepa_product: | ||
| self.action_confirm() | ||
| return self |
There was a problem hiding this comment.
the parent method doesn’t return anything, so this one shouldn’t either.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://gestion.coopiteasy.be/web#id=13411&action=475&active_id=605&model=project.task&view_type=form&menu_id=536
test fails because depends on #341